Build Windows installer and trusted signing foundation - #13
Merged
Conversation
Add a branded NSIS packaging pipeline, Windows artifact verification, a signing-gated GitHub workflow, and maintainer documentation to unblock testing under Smart App Control.
Replace the certificate-file path with SignPath's trusted GitHub artifact flow, add the required public code-signing policy, and keep unsigned PR builds clearly separated from approved releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this interrupts the active phase
Issue #12 prevents the project owner from launching the unsigned Electron development runtime while Windows Smart App Control remains enabled. A coherent, installable and testable baseline is part of the Phase 1 completion goal. This PR addresses that blocker only; it does not activate launcher, account or ecosystem development.
Validation completed
npm cinpm run checknpm run build:renderer:releasenpm audit --audit-level=high— 0 vulnerabilitiesSecurity boundary
No certificate, private key or password is stored in the repository. The release workflow signs only a GitHub Actions artifact through SignPath's trusted-build connector. Signed workflow runs require the protected
SIGNPATH_API_TOKEN, SignPath organization/project/policy variables andWINDOWS_EXPECTED_PUBLISHER. The workflow refuses to describe an unsigned artifact as signed.Completion boundary
This PR establishes and validates the installer and SignPath integration foundation. Issue #12 remains open until SignPath Foundation accepts Parlyn, the repository signing configuration is activated, and the resulting installer passes the documented maintainer test with Smart App Control enabled.