Conversation
…ctories Pass `true` for the `$recursive` parameter in all CLI migration commands so that migrations and seeders organized in subdirectories are automatically discovered. Affected commands: - migrations:run - migrations:fresh - migrations:rollback - migrations:dry-run - migrations:status Also moves legacy broken test fixtures out of App/Database/Migrations into tests/fixtures/ to prevent them from being picked up by recursive discovery. Closes #317
feat(migrations): enable recursive discovery in subdirectories
Add finally block to all migration commands to release the SchemaRunner's database connection after execution. This prevents connection leaks when running multiple commands in sequence (e.g., in test suites).
Test helper methods (initMigrations, dropSchemaTable) also create SchemaRunner instances that hold connections. Resetting the pool after each test ensures all connections are closed regardless of where they were created.
fix(migrations): close database connection after command execution
closes #319
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
============================================
+ Coverage 74.81% 74.99% +0.17%
- Complexity 3005 3015 +10
============================================
Files 97 97
Lines 9565 9589 +24
============================================
+ Hits 7156 7191 +35
+ Misses 2409 2398 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RouterUri::addMiddleware() now supports passing a fully qualified class name (e.g., StartSessionMiddleware::class). If the class extends AbstractMiddleware, it is instantiated and registered automatically. An InvalidArgumentException is thrown when a class-like string (containing a backslash) is passed but doesn't resolve to a valid middleware class. Plain name strings that don't match any registered middleware or group remain silent for backward compatibility. Closes #318
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.