fix(test): resolve all baseline test failures - #364
Merged
Conversation
- Add skip logic to MSSQL session tests when connection unavailable - Update AddDbConnectionCommandTest expected output to include sqlite option (added in database v2.2) - Update IntegrationAllCommandsTest expected output for sqlite - Fix shifted array indices in AddDbConnectionCommandTest All 784 tests now pass with 0 errors, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all pre-existing test failures so the test suite passes cleanly (0 errors, 0 failures).
Motivation
The test suite had 4 errors and 6 failures that were unrelated to any recent changes. These masked real regressions and made CI unreliable.
Changes
skipIfMssqlUnavailable()helper that marks tests as skipped when MSSQL container is unreachable (same pattern asMSSQLSessionStorageTest)"2: sqlite\n"(added by database v2.2 upgrade)How to Test / Verify
composer test10— 784 tests, 0 errors, 0 failures, 20 skipped (MSSQL tests when container unavailable).Breaking Changes and Migration Steps
None.
Checklist
Related issues
Not Applicable