Skip to content

Conversation

@seran
Copy link
Contributor

@seran seran commented Feb 25, 2025

No description provided.

@seran seran changed the title RestCallAction extension for Security Swagger Description inside Param extension for Security Feb 27, 2025
@seran seran marked this pull request as ready for review March 31, 2025 08:06
@seran seran requested a review from arcuri82 March 31, 2025 08:06
@arcuri82
Copy link
Collaborator

arcuri82 commented Apr 7, 2025

@seran hi, should I review this PR, or are u still working on it?

@seran
Copy link
Contributor Author

seran commented Apr 7, 2025

@seran hi, should I review this PR, or are u still working on it?

hi @arcuri82, I made a last minute change. I'll send you a PR review request once the CI is completed

@seran seran requested review from arcuri82 and removed request for arcuri82 May 13, 2025 20:32
*/
"path" -> params.add(PathParam(name, CustomMutationRateGene("d_", gene, 1.0)))
"header" -> params.add(HeaderParam(name, gene))
"header" -> params.add(HeaderParam(name, gene).apply { this.description = description })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this apply to all kinds of param? so could have the apply outside of the when

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are directly add the Param to the MutableList. So I added the description directly to other types also.

@seran seran requested a review from arcuri82 May 19, 2025 17:50
@arcuri82 arcuri82 merged commit 31f36de into master May 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants