Conversation
…t least two values if needed.
…o ensure satisfying minSize
…tLeastTwoKeyValues` method.
arcuri82
requested changes
Mar 19, 2026
core/src/main/kotlin/org/evomaster/core/search/gene/collection/MapGene.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/collection/MapGene.kt
Outdated
Show resolved
Hide resolved
| if (nextValue < getMinimum()) { | ||
| nextValue = getMinimum() | ||
| } | ||
| value = nextValue |
Collaborator
There was a problem hiding this comment.
i don't think we should go this, as we don't for the other genes. if one sets a value directly, we shouldn't silently modify it if it does not satisfy local constraints. usually, values are modified by the gene itself (eg mutation and randomization), which knows its own constraints.
why was this change made?
Collaborator
Author
There was a problem hiding this comment.
I discuss this issue in another branch
…domization logic.
…cted element size
arcuri82
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.