Gig create/update rejects venue-linked gigs (Invalid create gig data)

[JoshuaVSherman]

Summary

• Relax newGig's create guard (src/AgController/index.ts) to require datetime AND (venueId OR non-empty venue), dropping the hard city/usState/venue requirement that rejected every venue-linked gig from JaM's venue-picker.
• Apply the identical rule to updateGig in the same file, keeping the Failed gig update reports nothing: updateGig swallows its error, so neither socketError nor gigUpdated is emitted #253 rethrow behavior untouched.
• Relax src/model/gig/gig-schema.ts's venue field to required: false so Mongoose doesn't reject venue-linked docs that have no free-text venue.
• Add create/update tests in test/AgController/index.spec.ts covering: venue-linked payload succeeds, one-off free-text-venue payload succeeds, neither venueId nor venue still rejected, missing datetime still rejected.

Closes #256

How to test locally

Run:

npm test

Expect: eslint 0 errors, typecheck clean, all vitest suites green.

Exercise the change itself with a local socketcluster-server client (or via JaM's UI once JaMmusic#1254 is unblocked): connect, authenticate, then emit newGig with a venue-linked payload:

socket.transmit('newGig', {
  token: adminToken,
  gig: { venueId: 'EXISTING_VENUE_ID', datetime: new Date(), venue: '', city: '', usState: '' },
});

Expect: server publishes gigCreated (no socketError). Repeat with editGig/gigId and confirm gigUpdated is published. Then emit a payload with neither venueId nor venue and confirm socketError with Invalid create gig data (or Invalid gig data for edit) is transmitted.

Test evidence

✖ 105 problems (0 errors, 105 warnings)

> webjamsocketserver@3.0.12 typecheck
> tsc --noEmit

> webjamsocketserver@3.0.12 test:unit
> vitest run

 Test Files  10 passed (10)
      Tests  99 passed (99)
   Start at  20:21:52
   Duration  43.91s (transform 818ms, setup 0ms, import 3.36s, tests 47.24s, environment 2ms)

🤖 Work by Claude Code — Sonnet 5