Skip to content

Conversation

@youssefsoli
Copy link
Contributor

@youssefsoli youssefsoli commented Jun 21, 2022

187eb34

[GPUP] Send GPU preferences in single IPC message
https://bugs.webkit.org/show_bug.cgi?id=241809
rdar://95636552

Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-21
Reviewed by Eric Carlson.

Currently the `GPUProcessProxy::updatePreferences` method sends preferences
from the web process in multiple IPC messages to the GPU process. These messages
should be consolidated into one package and sent across in a single message.

* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::updateGPUProcessPreferences):
(WebKit::GPUProcess::updatePreference):
(WebKit::GPUProcess::setWebMParserEnabled): Deleted.
(WebKit::GPUProcess::setWebMFormatReaderEnabled): Deleted.
(WebKit::GPUProcess::setOpusDecoderEnabled): Deleted.
(WebKit::GPUProcess::setVorbisDecoderEnabled): Deleted.
(WebKit::GPUProcess::setMediaSourceInlinePaintingEnabled): Deleted.
(WebKit::GPUProcess::setSampleBufferContentKeySessionSupportEnabled): Deleted.
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/GPUProcess.messages.in:
* Source/WebKit/GPUProcess/GPUProcessPreferences.cpp: Added.
(WebKit::GPUProcessPreferences::encode const):
(WebKit::GPUProcessPreferences::decode):
* Source/WebKit/GPUProcess/GPUProcessPreferences.h: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updatePreferences):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/251713@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@youssefsoli youssefsoli added Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build labels Jun 21, 2022
@youssefsoli youssefsoli force-pushed the eng/GPUP-Send-GPU-preferences-in-single-IPC-message branch from 3958970 to 5b0d697 Compare June 21, 2022 21:42
@youssefsoli youssefsoli self-assigned this Jun 21, 2022
@youssefsoli youssefsoli requested a review from eric-carlson June 21, 2022 21:46
Comment on lines 328 to 331
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that if an m_preferences property hasn't been set, then it should default to false and call the global setters. Not sure if this assumption is correct.

@youssefsoli youssefsoli requested review from whsieh June 21, 2022 23:13
@youssefsoli youssefsoli force-pushed the eng/GPUP-Send-GPU-preferences-in-single-IPC-message branch from 5b0d697 to 94ba287 Compare June 21, 2022 23:51
@eric-carlson eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Jun 21, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GPUP-Send-GPU-preferences-in-single-IPC-message branch from 94ba287 to 187eb34 Compare June 22, 2022 01:16
@webkit-commit-queue webkit-commit-queue merged commit 187eb34 into WebKit:main Jun 22, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed r295708 (251713@main): https://commits.webkit.org/251713@main

Reviewed commits have been landed. Closing PR #1660 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants