Remove document.implementation.createCSSStyleSheet()

[karlcow]

7a15673

Remove document.implementation.createCSSStyleSheet()
https://bugs.webkit.org/show_bug.cgi?id=285157
rdar://142045904

The code has never been implemented in Firefox
https://bugzilla.mozilla.org/show_bug.cgi?id=63850

This was part of DOM Level 2
https://www.w3.org/TR/2000/REC-DOM-Level-2-Style-20001113/css.html#CSS-DOMImplementationCSS

Safari, Firefox and Chrome returns undefined
document.implementation.createCSSStyleSheet

* LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt: Removed.
* LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html: Removed.
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/webgl/2.0.0/resources/webgl_test_files/deqp/temp_externs/w3c_css.js:
(DOMImplementationCSS.prototype.createCSSStyleSheet): Deleted.
* Source/WebCore/dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet): Deleted.
* Source/WebCore/dom/DOMImplementation.h:
* Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMImplementation.cpp:
(webkit_dom_dom_implementation_create_css_style_sheet): Deleted.
* Source/WebKitLegacy/mac/DOM/DOMImplementation.h:
* Source/WebKitLegacy/mac/DOM/DOMImplementation.mm:
(-[DOMImplementation createCSSStyleSheet:media:]): Deleted.
(-[DOMImplementation createCSSStyleSheet::]): Deleted.

7a15673

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 2ff87a0)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[aproskuryakov]

We cannot modify released benchmarks.

Cf. https://bugs.webkit.org/show_bug.cgi?id=171825

[karlcow]

We cannot modify released benchmarks.

Cf. https://bugs.webkit.org/show_bug.cgi?id=171825

yes I thought about it when doing it.
Is there a way to skip the certain tests like for WPT?

[webkit-early-warning-system]

EWS run on current version of this PR (hash 7a15673)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[aproskuryakov]

I don't understand your question. Is it about performance benchmarks?

Another thing we shouldn't be doing is removing WebKitLegacy public APIs.

[karlcow]

Another thing we shouldn't be doing is removing WebKitLegacy public APIs.

I understand and agree but in this specific case, createCSSStyleSheet() has never been usable, which is why Firefox never implemented it.

see https://bugzilla.mozilla.org/show_bug.cgi?id=63850#c6 from 2002-06-13

This interface allows the DOM user to create a CSSStyleSheet outside the context of a document. There is no way to associate the new CSSStyleSheet with a document in DOM Level 2.

In other words, there is nothing useful you can do with the stylesheet it gives
you.

The missing piece of standard to associate the stylesheet to the DOM was never created. And then later on, it was removed from the spec, when people realized that there is nothing that could be done with it. So I doubt it's in any use elsewhere.

[aproskuryakov]

It's sometimes OK to leave in a stub API with empty implementation, but we can not "clean up" Objective-C APIs.

[annevk]

Instead of removing all this, use "return nil" as the body instead.

[annevk]

Maybe you can remove some of the includes.

[aproskuryakov]

This PR is probably best to be reviewed by @cdumez, as it revisits choices made in his 2017 change.