Skip to content

Remove document.implementation.createCSSStyleSheet() #38377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlcow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove document.implementation.createCSSStyleSheet() #38377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion LayoutTests/platform/mac-site-isolation/TestExpectations
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3580,7 +3580,6 @@ fast/css/case-insensitive-attribute-selector-styling-xhtml-2.xhtml [ Skip ]
fast/css/case-insensitive-attribute-selector-styling-xhtml-3.xhtml [ Skip ]
fast/css/center-align-absolute-position-inline-block.html [ Skip ]
fast/css/counters/counter-list-item.html [ Skip ]
fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html [ Skip ]
fast/css/DOMQuad-serialization.html [ Skip ]
fast/css/duplicated-after-pseudo-element.html [ Skip ]
fast/css/duplicated-before-pseudo-element.html [ Skip ]
Expand Down
9 changes: 0 additions & 9 deletions LayoutTests/webgl/2.0.0/resources/webgl_test_files/deqp/temp_externs/w3c_css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,15 +930,6 @@ DocumentCSS.prototype.getOverrideStyle = function(elt, pseudoElt) {};
*/
function DOMImplementationCSS() {}

/**
* @param {string} title
* @param {string} media
* @return {CSSStyleSheet}
* @see http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-DOMImplementationCSS-createCSSStyleSheet
* @throws DOMException {@see DomException.SYNTAX_ERR}
*/
DOMImplementationCSS.prototype.createCSSStyleSheet = function(title, media) {};

/**
* @constructor
* @see http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-ElementCSSInlineStyle
Expand Down
9 changes: 0 additions & 9 deletions Source/WebCore/dom/DOMImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,6 @@ ExceptionOr<Ref<XMLDocument>> DOMImplementation::createDocument(const AtomString
return document;
}

Ref<CSSStyleSheet> DOMImplementation::createCSSStyleSheet(const String&, const String& media)
{
// FIXME: Title should be set.
// FIXME: Media could have wrong syntax, in which case we should generate an exception.
auto sheet = CSSStyleSheet::create(StyleSheetContents::create());
sheet->setMediaQueries(MQ::MediaQueryParser::parse(media, { }));
return sheet;
}

Ref<HTMLDocument> DOMImplementation::createHTMLDocument(String&& title)
{
Ref document = HTMLDocument::create(nullptr, m_document->protectedSettings(), URL(), { });
Expand Down
1 change: 0 additions & 1 deletion Source/WebCore/dom/DOMImplementation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class DOMImplementation final : public ScriptWrappable {
WEBCORE_EXPORT ExceptionOr<Ref<XMLDocument>> createDocument(const AtomString& namespaceURI, const AtomString& qualifiedName, DocumentType*);
WEBCORE_EXPORT Ref<HTMLDocument> createHTMLDocument(String&& title);
static bool hasFeature() { return true; }
WEBCORE_EXPORT static Ref<CSSStyleSheet> createCSSStyleSheet(const String& title, const String& media);

static Ref<Document> createDocument(const String& contentType, LocalFrame*, const Settings&, const URL&, std::optional<ScriptExecutionContextIdentifier> = std::nullopt);

Expand Down
1 change: 0 additions & 1 deletion Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,6 @@ WI.NativePrototypeFunctionParameters = {
},

DOMImplementation: {
createCSSStyleSheet: "[title], [media]",
createDocument: "[namespaceURI], [qualifiedName], [doctype]",
createDocumentType: "[qualifiedName], [publicId], [systemId]",
createHTMLDocument: "[title]",
Expand Down
14 changes: 0 additions & 14 deletions Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,20 +155,6 @@ WebKitDOMDocument* webkit_dom_dom_implementation_create_document(WebKitDOMDOMImp
return WebKit::kit(result.releaseReturnValue().ptr());
}

WebKitDOMCSSStyleSheet* webkit_dom_dom_implementation_create_css_style_sheet(WebKitDOMDOMImplementation* self, const gchar* title, const gchar* media, GError** error)
{
WebCore::JSMainThreadNullState state;
g_return_val_if_fail(WEBKIT_DOM_IS_DOM_IMPLEMENTATION(self), 0);
g_return_val_if_fail(title, 0);
g_return_val_if_fail(media, 0);
g_return_val_if_fail(!error || !*error, 0);
WebCore::DOMImplementation* item = WebKit::core(self);
WTF::String convertedTitle = WTF::String::fromUTF8(title);
WTF::String convertedMedia = WTF::String::fromUTF8(media);
RefPtr<WebCore::CSSStyleSheet> gobjectResult = WTF::getPtr(item->createCSSStyleSheet(convertedTitle, convertedMedia));
return WebKit::kit(gobjectResult.get());
}

WebKitDOMHTMLDocument* webkit_dom_dom_implementation_create_html_document(WebKitDOMDOMImplementation* self, const gchar* title)
{
WebCore::JSMainThreadNullState state;
Expand Down
2 changes: 0 additions & 2 deletions Source/WebKitLegacy/mac/DOM/DOMImplementation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,11 @@ WEBKIT_CLASS_DEPRECATED_MAC(10_4, 10_14)
- (BOOL)hasFeature:(NSString *)feature version:(NSString *)version WEBKIT_AVAILABLE_MAC(10_5);
- (DOMDocumentType *)createDocumentType:(NSString *)qualifiedName publicId:(NSString *)publicId systemId:(NSString *)systemId WEBKIT_AVAILABLE_MAC(10_5);
- (DOMDocument *)createDocument:(NSString *)namespaceURI qualifiedName:(NSString *)qualifiedName doctype:(DOMDocumentType *)doctype WEBKIT_AVAILABLE_MAC(10_5);
- (DOMCSSStyleSheet *)createCSSStyleSheet:(NSString *)title media:(NSString *)media WEBKIT_AVAILABLE_MAC(10_5);
- (DOMHTMLDocument *)createHTMLDocument:(NSString *)title WEBKIT_AVAILABLE_MAC(10_5);
@end

@interface DOMImplementation (DOMImplementationDeprecated)
- (BOOL)hasFeature:(NSString *)feature :(NSString *)version WEBKIT_DEPRECATED_MAC(10_4, 10_5);
- (DOMDocumentType *)createDocumentType:(NSString *)qualifiedName :(NSString *)publicId :(NSString *)systemId WEBKIT_DEPRECATED_MAC(10_4, 10_5);
- (DOMDocument *)createDocument:(NSString *)namespaceURI :(NSString *)qualifiedName :(DOMDocumentType *)doctype WEBKIT_DEPRECATED_MAC(10_4, 10_5);
- (DOMCSSStyleSheet *)createCSSStyleSheet:(NSString *)title :(NSString *)media WEBKIT_DEPRECATED_MAC(10_4, 10_5);
@end
11 changes: 0 additions & 11 deletions Source/WebKitLegacy/mac/DOM/DOMImplementation.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ - (DOMDocument *)createDocument:(NSString *)namespaceURI qualifiedName:(NSString
return kit(raiseOnDOMError(unwrap(*self).createDocument(namespaceURI, qualifiedName, core(doctype))).ptr());
}

- (DOMCSSStyleSheet *)createCSSStyleSheet:(NSString *)title media:(NSString *)media
{
WebCore::JSMainThreadNullState state;
return kit(unwrap(*self).createCSSStyleSheet(title, media).ptr());
}

- (DOMHTMLDocument *)createHTMLDocument:(NSString *)title
{
WebCore::JSMainThreadNullState state;
Expand All @@ -105,11 +99,6 @@ - (DOMDocument *)createDocument:(NSString *)namespaceURI :(NSString *)qualifiedN
return [self createDocument:namespaceURI qualifiedName:qualifiedName doctype:doctype];
}

- (DOMCSSStyleSheet *)createCSSStyleSheet:(NSString *)title :(NSString *)media
{
return [self createCSSStyleSheet:title media:media];
}
Comment on lines -108 to -111
Copy link
Contributor

@annevk annevk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing all this, use "return nil" as the body instead.

Copy link
Contributor

@annevk annevk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can remove some of the includes.


@end

DOMImplementation *kit(WebCore::DOMImplementation* value)
Expand Down