Skip to content

Conversation

@JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented May 6, 2022

5562d2a

[git-webkit] Fail quickly for invalid bugzilla credentials
https://bugs.webkit.org/show_bug.cgi?id=240182
<rdar://problem/92879251 >

Reviewed by Stephanie Lewis.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Check credentials before creating an issue, exit
program if issue creation fails.

Canonical link: https://commits.webkit.org/250454@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this May 6, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels May 6, 2022
@JonWBedard JonWBedard requested a review from sundiamonde May 10, 2022 14:41
@JonWBedard JonWBedard force-pushed the eng/git-webkit-Exit-program-if-we-fail-to-create-a-bug branch 2 times, most recently from ac8c6ed to f470849 Compare May 10, 2022 20:34
@JonWBedard JonWBedard changed the title [git-webkit] Exit program if we fail to create a bug [git-webkit] Fail quickly for invalid bugzilla credentials May 10, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 10, 2022
Copy link
Contributor

@sundiamonde sundiamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves this instance but there were other places where we didn't fail if the credentials were wrong. I also think we need verify the credentials before we offer to save them.

@JonWBedard
Copy link
Member Author

JonWBedard commented May 10, 2022

This solves this instance but there were other places where we didn't fail if the credentials were wrong. I also think we need verify the credentials before we offer to save them.

Will look into another, more general, solution that prompts the user for credentials when we get 401s.

@JonWBedard JonWBedard removed the merging-blocked Applied to prevent a change from being merged label May 10, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-Exit-program-if-we-fail-to-create-a-bug branch from f470849 to d992e2a Compare May 10, 2022 23:22
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 5562d2a into WebKit:main May 10, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/git-webkit-Exit-program-if-we-fail-to-create-a-bug branch from d992e2a to 5562d2a Compare May 10, 2022 23:32
@webkit-early-warning-system
Copy link
Collaborator

Committed r294038 (250454@main): https://commits.webkit.org/250454@main

Reviewed commits have been landed. Closing PR #549 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2022
@JonWBedard JonWBedard deleted the eng/git-webkit-Exit-program-if-we-fail-to-create-a-bug branch May 19, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants