Skip to content

[GStreamer] Respect video decoding limits in MediaCapabilites queries#60868

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
eocanha:310192
Mar 18, 2026
Merged

[GStreamer] Respect video decoding limits in MediaCapabilites queries#60868
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
eocanha:310192

Conversation

@eocanha
Copy link
Contributor

@eocanha eocanha commented Mar 18, 2026

a8e8ac3

[GStreamer] Respect video decoding limits in MediaCapabilites queries
https://bugs.webkit.org/show_bug.cgi?id=310192

Reviewed by Xabier Rodriguez-Calvar.

The video decoding limits were only had into account in
supportsFeatures() so far. They should also be enforced by the
GStreamerRegistryScanner in isConfigurationSupported() as well.

See: WebPlatformForEmbedded/WPEWebKit#1639

This change checks the limits from isConfigurationSupported(), so it's
enforced from MediaCapabilities queries.

Original author: Andrzej Surdej (https://github.com/asurdej-comcast)

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Check the video decoding limits.

Canonical link: https://commits.webkit.org/309507@main

3f2cb6d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@eocanha eocanha requested a review from philn as a code owner March 18, 2026 17:18
@eocanha eocanha self-assigned this Mar 18, 2026
@eocanha eocanha added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 18, 2026
@eocanha eocanha requested review from calvaris and removed request for philn March 18, 2026 17:24
@eocanha eocanha added the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=310192

Reviewed by Xabier Rodriguez-Calvar.

The video decoding limits were only had into account in
supportsFeatures() so far. They should also be enforced by the
GStreamerRegistryScanner in isConfigurationSupported() as well.

See: WebPlatformForEmbedded/WPEWebKit#1639

This change checks the limits from isConfigurationSupported(), so it's
enforced from MediaCapabilities queries.

Original author: Andrzej Surdej (https://github.com/asurdej-comcast)

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Check the video decoding limits.

Canonical link: https://commits.webkit.org/309507@main
@webkit-commit-queue
Copy link
Collaborator

Committed 309507@main (a8e8ac3): https://commits.webkit.org/309507@main

Reviewed commits have been landed. Closing PR #60868 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a8e8ac3 into WebKit:main Mar 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants