Respect video decoding limits in MediaCapabilites queries#1639
Closed
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
Closed
Respect video decoding limits in MediaCapabilites queries#1639asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
Conversation
eocanha
added
the
upstream
eocanha
added a commit
to eocanha/WebKit
that referenced
this pull request
Mar 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=310192 Reviewed by NOBODY (OOPS!). The video decoding limits were only had into account in supportsFeatures() so far. They should also be enforced by the GStreamerRegistryScanner in isConfigurationSupported() as well. See: WebPlatformForEmbedded/WPEWebKit#1639 This change checks the limits from isConfigurationSupported(), so it's enforced from MediaCapabilities queries. Original author: Andrzej Surdej (https://github.com/asurdej-comcast) * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Check the video decoding limits.
Member
|
The patch looks good and has been submitted for upstream review as https://bugs.webkit.org/show_bug.cgi?id=310192 / WebKit/WebKit#60868. |
webkit-commit-queue
pushed a commit
to eocanha/WebKit
that referenced
this pull request
Mar 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=310192 Reviewed by Xabier Rodriguez-Calvar. The video decoding limits were only had into account in supportsFeatures() so far. They should also be enforced by the GStreamerRegistryScanner in isConfigurationSupported() as well. See: WebPlatformForEmbedded/WPEWebKit#1639 This change checks the limits from isConfigurationSupported(), so it's enforced from MediaCapabilities queries. Original author: Andrzej Surdej (https://github.com/asurdej-comcast) * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Check the video decoding limits. Canonical link: https://commits.webkit.org/309507@main
eocanha
pushed a commit
that referenced
this pull request
Mar 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=310192 Reviewed by Xabier Rodriguez-Calvar. The video decoding limits were only had into account in supportsFeatures() so far. They should also be enforced by the GStreamerRegistryScanner in isConfigurationSupported() as well. See: #1639 This change checks the limits from isConfigurationSupported(), so it's enforced from MediaCapabilities queries. Original author: Andrzej Surdej (https://github.com/asurdej-comcast) * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::isConfigurationSupported const): Check the video decoding limits. Canonical link: https://commits.webkit.org/309507@main
Member
|
The commit landed upstream as WebKit/WebKit@a8e8ac3 and was backported to wpe-2.46 as b665ab2. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e380190