Legacy EME generateKeyRequest returns a bogus destination URL due to leftover debug scaffolding

[cdumez]

116a737

Legacy EME generateKeyRequest returns a bogus destination URL due to leftover debug scaffolding
https://bugs.webkit.org/show_bug.cgi?id=320147

Reviewed by Jean-Yves Avenard.

RemoteLegacyCDMSessionProxy::generateKeyRequest() calls into the CDM's
generateKeyRequest(), which fills the destinationURL out-parameter with
the real key-request destination. However, a leftover test string
("this is a test string") unconditionally overwrote destinationURL
before it was passed back to the WebProcess via the completion handler.
This debug scaffolding has been present since the original 2020
implementation (221729@main). Remove it so the real destination URL
is returned.

* Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
(WebKit::RemoteLegacyCDMSessionProxy::generateKeyRequest): Remove the
leftover test-string assignment that clobbered the destinationURL
out-parameter.

Canonical link: https://commits.webkit.org/317970@main

8a99b27

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win	✅ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	⏳ 🧪 jsc-wpe
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-libwebrtc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision		✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 8a99b27)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win	✅ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	⏳ 🧪 jsc-wpe
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-libwebrtc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision		✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	🛠 watch
	✅ 🛠 watch-sim

[jyavenard]

lol

[webkit-commit-queue]

Committed 317970@main (116a737): https://commits.webkit.org/317970@main

Reviewed commits have been landed. Closing PR #70082 and removing active labels.