Web Inspector: Worker: bind delayed heap events to the current run loop#70091
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 8d79527) Details |
Constellation
approved these changes
Jul 24, 2026
https://bugs.webkit.org/show_bug.cgi?id=320159 Reviewed by Yusuke Suzuki. * Source/WebCore/inspector/agents/WebHeapAgent.cpp: (WebCore::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask): Use the current `RunLoop` so that `Worker` teardown stops the `Timer` on the thread that owns it. * LayoutTests/inspector/worker/heap-gc.html: Added. * LayoutTests/inspector/worker/heap-gc-expected.txt: Added. Canonical link: https://commits.webkit.org/317842@main
webkit-commit-queue
force-pushed
the
eng/320159
branch
from
July 24, 2026 06:07
8d79527 to
c608bab
Compare
Collaborator
|
Committed 317842@main (c608bab): https://commits.webkit.org/317842@main Reviewed commits have been landed. Closing PR #70091 and removing active labels. |
Contributor
|
thanks for fixing this, I was tracking it down today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 mac-site-isolation
c608bab
8d79527
🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios🧪 mac-wk2🛠 ios-safer-cpp🧪 mac-AS-debug-wk2🧪 mac-intel-wk2🛠 mac-safer-cpp