Skip to content

Web Inspector: Worker: bind delayed heap events to the current run loop#70091

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
dcrousso:eng/320159
Jul 24, 2026
Merged

Web Inspector: Worker: bind delayed heap events to the current run loop#70091
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
dcrousso:eng/320159

Conversation

@dcrousso

@dcrousso dcrousso commented Jul 24, 2026

Copy link
Copy Markdown
Member

c608bab

Web Inspector: Worker: bind delayed heap events to the current run loop
https://bugs.webkit.org/show_bug.cgi?id=320159

Reviewed by Yusuke Suzuki.

* Source/WebCore/inspector/agents/WebHeapAgent.cpp:
(WebCore::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
Use the current `RunLoop` so that `Worker` teardown stops the `Timer` on the thread that owns it.

* LayoutTests/inspector/worker/heap-gc.html: Added.
* LayoutTests/inspector/worker/heap-gc-expected.txt: Added.

Canonical link: https://commits.webkit.org/317842@main

8d79527

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
🛠 ios-safer-cpp 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🧪 vision-wk2 🛠 mac-safer-cpp
✅ 🛠 tv loading 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@dcrousso dcrousso self-assigned this Jul 24, 2026
@dcrousso dcrousso added the Web Inspector Bugs related to the WebKit Web Inspector. label Jul 24, 2026
@dcrousso dcrousso added the merge-queue Applied to send a pull request to merge-queue label Jul 24, 2026
https://bugs.webkit.org/show_bug.cgi?id=320159

Reviewed by Yusuke Suzuki.

* Source/WebCore/inspector/agents/WebHeapAgent.cpp:
(WebCore::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
Use the current `RunLoop` so that `Worker` teardown stops the `Timer` on the thread that owns it.

* LayoutTests/inspector/worker/heap-gc.html: Added.
* LayoutTests/inspector/worker/heap-gc-expected.txt: Added.

Canonical link: https://commits.webkit.org/317842@main
@webkit-commit-queue

Copy link
Copy Markdown
Collaborator

Committed 317842@main (c608bab): https://commits.webkit.org/317842@main

Reviewed commits have been landed. Closing PR #70091 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit c608bab into WebKit:main Jul 24, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 24, 2026
@dcrousso
dcrousso deleted the eng/320159 branch July 24, 2026 06:22
@burg

burg commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

thanks for fixing this, I was tracking it down today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Inspector Bugs related to the WebKit Web Inspector.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants