corner-shape: non-round corner shapes are ignored for composited content (<video>, images, composited descendants) by cupidsity · Pull Request #71079 · WebKit/WebKit

cupidsity · 2026-08-06T20:37:57Z

`e303a71`

corner-shape: non-round corner shapes are ignored for composited content (<video>, images, composited descendants)
https://bugs.webkit.org/show_bug.cgi?id=321194
rdar://184258503

Reviewed by Simon Fraser.

This adds a shape mask for the cases the layer can clip itself, and
refuses the directly-composited fast paths for the cases it can't

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/LayerAncestorClippingStack.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateBackdropFiltersGeometry):
(WebCore::RenderLayerBacking::updateAppleVisualEffect):
(WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::contentsClippingRectForCornerShape):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):
(WebCore::RenderLayerBacking::updateContentsRects):
(WebCore::boxNeedingShapeMaskForClip):
(WebCore::RenderLayerBacking::ensureClippingStackLayers):
(WebCore::RenderLayerBacking::removeClippingStackLayers):
(WebCore::RenderLayerBacking::updateClippingStackLayerGeometry):
(WebCore::RenderLayerBacking::needsCornerShapeMask const):
(WebCore::RenderLayerBacking::updateMaskingLayer):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage const):
(WebCore::setContentsClipShapePath):
* Source/WebCore/rendering/RenderLayerBacking.h:
* Source/WebCore/rendering/style/BorderData.cpp:
(WebCore::BorderData::hasNonRoundCornerShape const):
(WebCore::BorderData::hasCornerShapeOutsideBorderRadius const):
(WebCore::BorderData::hasCornerShapeOutsideRoundedRect const):
* Source/WebCore/rendering/style/BorderData.h:
* LayoutTests/compositing/video/corner-shape-video-expected.html: Added.
* LayoutTests/compositing/video/corner-shape-video-overflow-expected.html: Added.
* LayoutTests/compositing/video/corner-shape-video-overflow.html: Added.
* LayoutTests/compositing/video/corner-shape-video.html: Added.
* Source/WebCore/rendering/LayerAncestorClippingStack.cpp:
(WebCore::LayerAncestorClippingStack::LayerAncestorClippingStack):
(WebCore::LayerAncestorClippingStack::updateWithClipData):
(WebCore::operator<<):
* Source/WebCore/platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::contentsClipShapePath const):
(WebCore::GraphicsLayer::setContentsClipShapePath):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::contentsClipShapePathsAreEqual):
(WebCore::GraphicsLayerCA::setContentsClipShapePath):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::setShapeLayerPath):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* LayoutTests/compositing/corner-shape-ancestor-clip-expected.html: Added.
* LayoutTests/compositing/corner-shape-ancestor-clip.html: Added.
* LayoutTests/compositing/corner-shape-mask-layer-offset-expected.html: Added.
* LayoutTests/compositing/corner-shape-mask-layer-offset.html: Added.
* LayoutTests/compositing/corner-shape-ancestor-clip-shape-mask-expected.txt: Added.
* LayoutTests/compositing/corner-shape-ancestor-clip-shape-mask.html: Added.
* LayoutTests/fast/scrolling/corner-shape-nested-clips-overflow-scroll-expected.html: Added.
* LayoutTests/fast/scrolling/corner-shape-nested-clips-overflow-scroll.html: Added.
* LayoutTests/fast/scrolling/corner-shape-overflow-scroll-uneven-radii-expected.html: Added.
* LayoutTests/fast/scrolling/corner-shape-overflow-scroll-uneven-radii.html: Added.
* Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.cpp:
(WebCore::SkiaCompositingLayer::paintContents):
(WebCore::SkiaCompositingLayer::paintSelfAndChildren):
* Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp:
(WebCore::CoordinatedPlatformLayer::setContentsClipShapePath):
(WebCore::CoordinatedPlatformLayer::flushCompositingStateOnTarget):
(WebCore::CoordinatedPlatformLayer::flushCompositingStateOnSkiaTarget):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h:
* Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.cpp:
(WebCore::GraphicsLayerCoordinated::setContentsClipShapePath):
(WebCore::GraphicsLayerCoordinated::setShapeLayerPath):
(WebCore::GraphicsLayerCoordinated::commitLayerChanges):
* Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.h:

Canonical link: https://commits.webkit.org/319257@main

b7ab564

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2-stress	✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-06T20:38:03Z

EWS run on previous version of this PR (hash 4157550)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	~~🧪 jsc-wpe~~
~~🧪 jsc-x86-64~~	❌ 🧪 api-ios	~~🧪 mac-wk2~~	~~🛠 gtk3-gcc~~
	~~🛠 ios-safer-cpp~~	❌ 🧪 mac-AS-debug-wk2	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-wk2-stress~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-intel-wk2~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🛠 mac-safer-cpp~~	~~🛠 playstation~~
	❌ 🛠 tv	~~🧪 mac-site-isolation~~
	❌ 🛠 tv-sim
	~~🛠 watch~~
	❌ 🛠 watch-sim

webkit-early-warning-system · 2026-08-06T20:44:22Z

EWS run on previous version of this PR (hash c0af633)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	~~🧪 api-mac-debug~~	~~🧪 jsc-wpe~~
~~🧪 jsc-x86-64~~	❌ 🧪 api-ios	~~🧪 mac-wk2~~	~~🛠 gtk3-gcc~~
	~~🛠 ios-safer-cpp~~	~~🧪 mac-AS-debug-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-wk2-stress~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-intel-wk2~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🛠 mac-safer-cpp~~	~~🛠 playstation~~
	❌ 🛠 tv	~~🧪 mac-site-isolation~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2026-08-06T20:48:49Z

EWS run on previous version of this PR (hash 89177bc)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	❌ 🧪 jsc-wpe
❌ 🧪 jsc-x86-64	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk3-gcc
	❌ 🛠 ios-safer-cpp	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-intel-wk2	❌ 🧪 api-gtk
	❌ 🧪 vision-wk2	❌ 🛠 mac-safer-cpp	❌ 🛠 playstation
	❌ 🛠 tv	❌ 🧪 mac-site-isolation
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2026-08-06T21:04:32Z

EWS run on previous version of this PR (hash e94d80f)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	~~🧪 api-mac-debug~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	❌ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-intel-wk2~~	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-06T21:22:25Z

EWS run on previous version of this PR (hash f38a271)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
🧪 webkitpy	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-intel-wk2~~	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-06T23:22:40Z

EWS run on previous version of this PR (hash ab0c585)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	❌ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-12T17:28:43Z

EWS run on previous version of this PR (hash 979fc43)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-12T20:26:10Z

EWS run on previous version of this PR (hash a83ff59)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-14T20:26:10Z

EWS run on previous version of this PR (hash b51259f)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~
~~🧪 jsc-x86-64~~	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk3-gcc
	~~🛠 ios-safer-cpp~~	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-wk2-stress~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-intel-wk2~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🛠 mac-safer-cpp~~	✅ 🛠 playstation
	~~🛠 tv~~	~~🧪 mac-site-isolation~~
	✅ 🛠 tv-sim
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2026-08-14T20:38:38Z

EWS run on previous version of this PR (hash d80fa83)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk3-gcc
	~~🛠 ios-safer-cpp~~	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-intel-wk2~~	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	~~🛠 mac-safer-cpp~~	✅ 🛠 playstation
	✅ 🛠 tv	❌ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-14T22:16:21Z

EWS run on previous version of this PR (hash 349a17b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~
	~~🧪 api-ios~~	❌ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	~~🧪 mac-AS-debug-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-intel-wk2~~	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	~~🛠 mac-safer-cpp~~	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-15T01:15:25Z

EWS run on previous version of this PR (hash 9703b9e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-wk2-stress	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	❌ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-08-16T18:28:38Z

EWS run on current version of this PR (hash b7ab564)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk3-gcc
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-wk2-stress	✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-intel-wk2	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🛠 mac-safer-cpp	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🧪 mac-site-isolation
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

…ent (<video>, images, composited descendants) https://bugs.webkit.org/show_bug.cgi?id=321194 rdar://184258503 Reviewed by Simon Fraser. This adds a shape mask for the cases the layer can clip itself, and refuses the directly-composited fast paths for the cases it can't * LayoutTests/TestExpectations: * Source/WebCore/rendering/LayerAncestorClippingStack.h: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::updateBackdropFiltersGeometry): (WebCore::RenderLayerBacking::updateAppleVisualEffect): (WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange): (WebCore::RenderLayerBacking::updateConfiguration): (WebCore::contentsClippingRectForCornerShape): (WebCore::RenderLayerBacking::updateGeometry): (WebCore::RenderLayerBacking::updateMaskingLayerGeometry): (WebCore::RenderLayerBacking::updateContentsRects): (WebCore::boxNeedingShapeMaskForClip): (WebCore::RenderLayerBacking::ensureClippingStackLayers): (WebCore::RenderLayerBacking::removeClippingStackLayers): (WebCore::RenderLayerBacking::updateClippingStackLayerGeometry): (WebCore::RenderLayerBacking::needsCornerShapeMask const): (WebCore::RenderLayerBacking::updateMaskingLayer): (WebCore::supportsDirectlyCompositedBoxDecorations): (WebCore::RenderLayerBacking::isDirectlyCompositedImage const): (WebCore::setContentsClipShapePath): * Source/WebCore/rendering/RenderLayerBacking.h: * Source/WebCore/rendering/style/BorderData.cpp: (WebCore::BorderData::hasNonRoundCornerShape const): (WebCore::BorderData::hasCornerShapeOutsideBorderRadius const): (WebCore::BorderData::hasCornerShapeOutsideRoundedRect const): * Source/WebCore/rendering/style/BorderData.h: * LayoutTests/compositing/video/corner-shape-video-expected.html: Added. * LayoutTests/compositing/video/corner-shape-video-overflow-expected.html: Added. * LayoutTests/compositing/video/corner-shape-video-overflow.html: Added. * LayoutTests/compositing/video/corner-shape-video.html: Added. * Source/WebCore/rendering/LayerAncestorClippingStack.cpp: (WebCore::LayerAncestorClippingStack::LayerAncestorClippingStack): (WebCore::LayerAncestorClippingStack::updateWithClipData): (WebCore::operator<<): * Source/WebCore/platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::contentsClipShapePath const): (WebCore::GraphicsLayer::setContentsClipShapePath): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::contentsClipShapePathsAreEqual): (WebCore::GraphicsLayerCA::setContentsClipShapePath): (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::setShapeLayerPath): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * LayoutTests/compositing/corner-shape-ancestor-clip-expected.html: Added. * LayoutTests/compositing/corner-shape-ancestor-clip.html: Added. * LayoutTests/compositing/corner-shape-mask-layer-offset-expected.html: Added. * LayoutTests/compositing/corner-shape-mask-layer-offset.html: Added. * LayoutTests/compositing/corner-shape-ancestor-clip-shape-mask-expected.txt: Added. * LayoutTests/compositing/corner-shape-ancestor-clip-shape-mask.html: Added. * LayoutTests/fast/scrolling/corner-shape-nested-clips-overflow-scroll-expected.html: Added. * LayoutTests/fast/scrolling/corner-shape-nested-clips-overflow-scroll.html: Added. * LayoutTests/fast/scrolling/corner-shape-overflow-scroll-uneven-radii-expected.html: Added. * LayoutTests/fast/scrolling/corner-shape-overflow-scroll-uneven-radii.html: Added. * Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.cpp: (WebCore::SkiaCompositingLayer::paintContents): (WebCore::SkiaCompositingLayer::paintSelfAndChildren): * Source/WebCore/platform/graphics/skia/SkiaCompositingLayer.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.cpp: (WebCore::CoordinatedPlatformLayer::setContentsClipShapePath): (WebCore::CoordinatedPlatformLayer::flushCompositingStateOnTarget): (WebCore::CoordinatedPlatformLayer::flushCompositingStateOnSkiaTarget): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedPlatformLayer.h: * Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.cpp: (WebCore::GraphicsLayerCoordinated::setContentsClipShapePath): (WebCore::GraphicsLayerCoordinated::setShapeLayerPath): (WebCore::GraphicsLayerCoordinated::commitLayerChanges): * Source/WebCore/platform/graphics/texmap/coordinated/GraphicsLayerCoordinated.h: Canonical link: https://commits.webkit.org/319257@main

webkit-commit-queue · 2026-08-16T23:10:44Z

Committed 319257@main (e303a71): https://commits.webkit.org/319257@main

Reviewed commits have been landed. Closing PR #71079 and removing active labels.

cupidsity self-assigned this Aug 6, 2026

cupidsity added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Aug 6, 2026

cupidsity force-pushed the video-corner-shape branch from 4157550 to c0af633 Compare August 6, 2026 20:44

cupidsity force-pushed the video-corner-shape branch from c0af633 to 89177bc Compare August 6, 2026 20:48

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

cupidsity force-pushed the video-corner-shape branch from 89177bc to e94d80f Compare August 6, 2026 21:04

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

cupidsity force-pushed the video-corner-shape branch from e94d80f to f38a271 Compare August 6, 2026 21:22

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 6, 2026

cupidsity force-pushed the video-corner-shape branch from f38a271 to ab0c585 Compare August 6, 2026 23:22

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 7, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 12, 2026

cupidsity force-pushed the video-corner-shape branch from ab0c585 to 979fc43 Compare August 12, 2026 17:28

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 12, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 12, 2026

cupidsity force-pushed the video-corner-shape branch from 979fc43 to a83ff59 Compare August 12, 2026 20:26

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 12, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 12, 2026

cupidsity force-pushed the video-corner-shape branch from a83ff59 to 03fbc19 Compare August 12, 2026 22:55

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 13, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 13, 2026

cupidsity force-pushed the video-corner-shape branch from 4a69c45 to 69d607e Compare August 13, 2026 21:17

cupidsity requested review from alexgcastro, carlosgcampos, magomez and nikolaszimmermann as code owners August 13, 2026 21:17

smfr approved these changes Aug 14, 2026

View reviewed changes

cupidsity force-pushed the video-corner-shape branch from 69d607e to b51259f Compare August 14, 2026 20:26

cupidsity force-pushed the video-corner-shape branch from b51259f to d80fa83 Compare August 14, 2026 20:38

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 14, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 14, 2026

cupidsity force-pushed the video-corner-shape branch from d80fa83 to 349a17b Compare August 14, 2026 22:16

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 15, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 15, 2026

cupidsity force-pushed the video-corner-shape branch from 349a17b to 9703b9e Compare August 15, 2026 01:15

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 15, 2026

cupidsity removed the merging-blocked Applied to prevent a change from being merged label Aug 16, 2026

cupidsity force-pushed the video-corner-shape branch from 9703b9e to b7ab564 Compare August 16, 2026 18:28

cupidsity added the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2026

webkit-commit-queue force-pushed the video-corner-shape branch from b7ab564 to e303a71 Compare August 16, 2026 23:10

webkit-commit-queue merged commit e303a71 into WebKit:main Aug 16, 2026

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2026

Uh oh!

Conversation

cupidsity commented Aug 6, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

e303a71

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cupidsity commented Aug 6, 2026 •

edited by webkit-early-warning-system

Loading

`e303a71`

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 6, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 12, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 12, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 14, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 14, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 14, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 15, 2026 •

edited

Loading

webkit-early-warning-system commented Aug 16, 2026 •

edited

Loading