Add double requestAnimationFrame wait before reftest/crashtest snapshot - #71591
Draft
gsnedders wants to merge 1 commit into
Draft
Add double requestAnimationFrame wait before reftest/crashtest snapshot#71591gsnedders wants to merge 1 commit into
gsnedders wants to merge 1 commit into
Conversation
Implement the WPT test-wait.js behavior (two nested requestAnimationFrame ticks before completion) in both WebKitTestRunner and DumpRenderTree. This ensures in-page rAF-scheduled work (fonts, scroll callbacks, focus styling) completes before snapshot, fixing flakiness seen in prior commits b06fede, 136c73f, and 300a053. The implementation adds shared JSC helpers in WPTFunctions that schedule nested rAF callbacks before invoking a completion handler, and gates the existing "dump" calls in both runners' polling loops behind this wait. Forced/timeout completion still dumps immediately, bypassing the rAF wait. Files: Tools/TestRunnerShared/WPTFunctions.{h,cpp} for shared helpers, Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp for WKTR, and Tools/DumpRenderTree/mac/FrameLoadDelegate.mm for DRT.
Collaborator
|
EWS run on current version of this PR (hash d873679) Details |
🛠 wpe
webkit-ews-buildbot
added
the
merging-blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Very much an experimental throwaway for now, here to gather results from EWS.)
d873679