Skip to content

[GStreamer][WebCodecs] Ensure GStreamer is initialized when creating PlatformRawAudioData - #71755

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
philn:eng/321913
Aug 18, 2026
Merged

[GStreamer][WebCodecs] Ensure GStreamer is initialized when creating PlatformRawAudioData#71755
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
philn:eng/321913

Conversation

@philn

@philn philn commented Aug 17, 2026 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Member

0b7beb9

[GStreamer][WebCodecs] Ensure GStreamer is initialized when creating PlatformRawAudioData
https://bugs.webkit.org/show_bug.cgi?id=321913

Reviewed by Alicia Boya Garcia.

Make sure GStreamer is initialized, or creating a WebCodecs AudioData from JS might trigger a
WebProcess crash.

* Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:
(WebCore::PlatformRawAudioData::create):

Canonical link: https://commits.webkit.org/319360@main

2492212

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ❌ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Aug 17, 2026
@webkit-early-warning-system

webkit-early-warning-system commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash 2492212)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ❌ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Aug 17, 2026
@philn
philn requested a review from a team August 17, 2026 08:11
@philn philn added GLib Suggested Backport - 2.52 Suggest this merge request be backported to the webkitglib/2.52 stable branch GLib Suggested Backport - 2.54 Suggest this merge request be backported to webkitglib/2.54 branch labels Aug 17, 2026
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Aug 18, 2026
@philn
[GStreamer][WebCodecs] Ensure GStreamer is initialized when creating …
0b7beb9 
…PlatformRawAudioData

https://bugs.webkit.org/show_bug.cgi?id=321913

Reviewed by Alicia Boya Garcia.

Make sure GStreamer is initialized, or creating a WebCodecs AudioData from JS might trigger a
WebProcess crash.

* Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:
(WebCore::PlatformRawAudioData::create):

Canonical link: https://commits.webkit.org/319360@main
@webkit-commit-queue

webkit-commit-queue commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Committed 319360@main (0b7beb9): https://commits.webkit.org/319360@main

Reviewed commits have been landed. Closing PR #71755 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit 0b7beb9 into WebKit:main Aug 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 18, 2026
@philn
philn deleted the eng/321913 branch August 18, 2026 11:50
@aperezdc

aperezdc commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Backported into webkitglib/2.52 as commit 749805d

@aperezdc aperezdc removed the GLib Suggested Backport - 2.52 Suggest this merge request be backported to the webkitglib/2.52 stable branch label Aug 18, 2026
@carlosgcampos

carlosgcampos commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Backported to 2.54

@carlosgcampos carlosgcampos removed the GLib Suggested Backport - 2.54 Suggest this merge request be backported to webkitglib/2.54 branch label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntrrgc ntrrgc ntrrgc approved these changes

Assignees

@philn philn

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@philn @webkit-early-warning-system @webkit-commit-queue @aperezdc @carlosgcampos @ntrrgc