Structure API revamp - #20
Closed
noone-075 wants to merge 12 commits into
Closed
Conversation
- structures are now built per location/seed instead of being singleton instances - added chunk-aware placement and slicing via PlaceableStructure and getChunk(...) - structures can now be used directly in a ChunkGenerator workflow - added AbstractGenerableStructure.locateNearest(...) for generation lookup - updated HerobrineShrineTestStructure and RickQRCodeTestSchemStructure to the new API - removed getInstance() usage; construct structure objects directly - simplified the wlib debug command to select by name instead of using clazz - kept a registration helper for centralized structure discovery
colbster937
requested changes
Sep 1, 2026
- fixed all errors from @colbster937's review - changed some if chains to switch statements (WLIBCommand.java) - dependency-reduced-pom.xml is now in my local .gitignore
noone-075
commented
Sep 2, 2026
noone-075
left a comment
noone-075
left a comment
Contributor
Author
There was a problem hiding this comment.
ok then its ready, keep open until you push 1.3.0
colbster937
marked this pull request as ready for review
September 2, 2026 11:48
colbster937
marked this pull request as draft
September 2, 2026 11:48
colbster937
requested changes
Sep 2, 2026
colbster937
left a comment
colbster937
left a comment
Member
There was a problem hiding this comment.
should be the only things left to change until the 1.3.0 merge
update deps
- HerobrineShrineTestStructure now extends AbstractGenerableStructure instead of AbstractBaseStructure - Added getGenerationSeed method to AbstractGenerableStructure - fixed review comments - fix code issues
colbster937
requested changes
Sep 2, 2026
Member
|
@noone-075 I've submitted a PR to your fork (noone-075#2) that fixes most of the issues, but i wont be merging this until the legacy api is compatible. once i end up removing the legacy api in a future update, then we can go back to the current proposed system. I'd also like to point out that WLIB's structure system is NOT specifically for generating structures naturally (even though thats what dblk uses it for), therefore we don't need anything related to it. |
chore: fix issues that i can
Contributor
Author
|
new pr here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created but waiting for 1.3.0 to be released