Skip to content

Fix controller rotation authentication handling - #451

Merged
kentbull merged 1 commit into
WebOfTrust:mainfrom
kentbull:fix/controller-rotation-authentication-contract
Jul 21, 2026
Merged

Fix controller rotation authentication handling#451
kentbull merged 1 commit into
WebOfTrust:mainfrom
kentbull:fix/controller-rotation-authentication-contract

Conversation

@kentbull

Copy link
Copy Markdown
Collaborator

Follow-up to PR #351.

Treat SignedHeaderAuthenticator.inbound() as validate-or-raise in the agent rotation handler, translating authentication failures to the existing 403 response.

Tests: uv run pytest -q tests/ (76 passed).

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.24%. Comparing base (4b7eb6c) to head (ba5001d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   88.02%   88.24%   +0.22%     
==========================================
  Files          26       26              
  Lines        5929     5931       +2     
==========================================
+ Hits         5219     5234      +15     
+ Misses        710      697      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Treat SignedHeaderAuthenticator.inbound() as validate-or-raise in the agent rotation handler. Successful signed requests now continue after a normal return, while authentication and malformed-header errors are translated to the existing forbidden response.
@kentbull
kentbull force-pushed the fix/controller-rotation-authentication-contract branch from 460ecfe to ba5001d Compare July 21, 2026 16:02
@kentbull
kentbull merged commit f6dbdbf into WebOfTrust:main Jul 21, 2026
6 checks passed
@kentbull
kentbull deleted the fix/controller-rotation-authentication-contract branch July 22, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants