Default Tiger-paw favicon on every page (public + admin), Site Identity override - #104
Merged
Conversation
- Identity_Plugin_Favicon now emits a baked-in Tiger paw default (DEFAULT_FAVICON, a puma base-theme asset served at the always-present /_theme base) when Site Identity sets no favicon — so every page has one out of the box; a configured favicon still overrides it. - The admin + auth shells now render $this->headLink(), so the favicon (and any head-registry links) appear there too — previously only the public shell did, which is why the admin panel had no favicon. - Ship the paw at themes/puma/assets/img/tiger-favicon.png (baked into tiger-core). - FaviconPluginTest: unset / unresolvable now assert the default paw, not silence. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stock Tiger paw favicon now shows on every surface out of the box, overridable by Site Identity.
Identity_Plugin_Faviconfalls back to a baked-in paw (DEFAULT_FAVICON, a puma base-theme asset at the always-present/_themebase) whentiger.site.faviconis unset/unresolvable. A configured favicon still wins.headLink()— previously only the public shell did, so the admin panel had no favicon.themes/puma/assets/img/tiger-favicon.png(baked into tiger-core).<link>renders on public/auth/CMS; the configured Site Identity icon correctly overrides the default.🤖 Generated with Claude Code