Skip to content

feat: use libnss-wrapper for uid mapping#4392

Merged
nijel merged 1 commit intoWeblateOrg:mainfrom
nijel:uid-compat
Apr 7, 2026
Merged

feat: use libnss-wrapper for uid mapping#4392
nijel merged 1 commit intoWeblateOrg:mainfrom
nijel:uid-compat

Conversation

@nijel
Copy link
Copy Markdown
Member

@nijel nijel commented Apr 7, 2026

It is added into the base image in WeblateOrg/docker-base#500

@nijel nijel requested a review from Copilot April 7, 2026 06:42
@nijel nijel self-assigned this Apr 7, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the container startup flow to support OpenShift / arbitrary-UID runtime environments by using libnss-wrapper for passwd/group resolution instead of modifying /etc/passwd, aligning with the base image change referenced in WeblateOrg/docker-base#500.

Changes:

  • Add libnss-wrapper detection and NSS-wrapper-based passwd/group mapping in start.
  • Stop making /etc/passwd and /etc/group writable in the image build; clarify su hardening comments.
  • Ignore /.codex in .gitignore.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
start Adds libnss-wrapper-based NSS mapping for arbitrary UIDs with a fallback path when /etc/passwd is writable.
Dockerfile Removes the chmod that allowed passwd/group edits; updates commentary around su hardening.
.gitignore Adds /.codex ignore rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread start Outdated
Comment thread start Outdated
@nijel nijel enabled auto-merge (rebase) April 7, 2026 06:50
@nijel nijel merged commit ea58ef6 into WeblateOrg:main Apr 7, 2026
43 checks passed
@nijel nijel deleted the uid-compat branch April 7, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants