Skip to content

refactor: migrate to keyring-core and reusable workflows - #6

Merged
WeekendSuperhero merged 6 commits into
mainfrom
weekendsuperhero/css_cleanup
Apr 10, 2026
Merged

refactor: migrate to keyring-core and reusable workflows#6
WeekendSuperhero merged 6 commits into
mainfrom
weekendsuperhero/css_cleanup

Conversation

@WeekendSuperhero

@WeekendSuperhero WeekendSuperhero commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaced secret-lib with keyring-core and native OS keyring stores.
  • Migrated CI/CD pipelines to utilize reusable workflows.
  • Added new workflows for updating PR descriptions and changelogs.

Changes

Secrets Management

  • Added src/secret.rs implementing Raw, Keyring, and Command backends.
  • Updated Cargo.toml with platform-specific keyring dependencies.
  • Configured native keyring stores in main.rs for Windows, macOS, and Linux.

CI/CD Workflows

  • Updated ci.yml and release.yml to use centralized reusable workflows.
  • Added Linux build dependencies (libdbus-1-dev, pkg-config) to workflow configs.
  • Added .github/workflows/changelog.yml and .github/workflows/pr-desc.yml.

Test plan

  • Verify successful compilation across Windows, macOS, and Linux.
  • Ensure CI pipeline passes including the DBus dependency installation.
  • Validate that storing/retrieving passwords interacts properly with the OS native keyring.

PR description generated by Agent

Comment thread .github/workflows/ci.yml
Comment on lines +11 to +17
uses: weekendsuperhero-io/platform-tools/.github/workflows/reusable-rust-ci.yml@main
with:
check-os-json: '["ubuntu-latest","macos-latest","windows-latest"]'
rust-cache-provider: github
docs-os: ubuntu-latest
linux-packages: "libdbus-1-dev pkg-config"
build-matrix-json: "[]"
Comment on lines +9 to +12
uses: weekendsuperhero-io/platform-tools/.github/workflows/reusable-pr-description.yml@main
with:
trigger-phrase: "@agent pr-title" # optional — only runs if this phrase is in the PR body
secrets: inherit
Comment on lines +10 to +31
uses: weekendsuperhero-io/platform-tools/.github/workflows/reusable-rust-release.yml@main
with:
validate-runs-on: ubuntu-latest
rust-cache-provider: github
validate-linux-packages: "libdbus-1-dev pkg-config"
# Optional override if binary cannot be inferred from Cargo.toml
# binary-name: agentmail
binary-matrix-json: >-
[
{"name":"linux-x86_64","os":"ubuntu-latest","target":"x86_64-unknown-linux-gnu"},
{"name":"linux-aarch64","os":"ubuntu-24.04-arm","target":"aarch64-unknown-linux-gnu"},
{"name":"macos-x86_64","os":"macos-latest","target":"x86_64-apple-darwin"},
{"name":"macos-aarch64","os":"macos-latest","target":"aarch64-apple-darwin"},
{"name":"windows-x86_64","os":"windows-latest","target":"x86_64-pc-windows-msvc"}
]
enable-macos-universal: true
# Optional overrides if your artifact names differ:
# macos-universal-arm64-artifact: macos-aarch64
# macos-universal-x86_64-artifact: macos-x86_64
publish-crates-io: true
cargo-publish-command: cargo publish
secrets: inherit
@agent-pr-updater agent-pr-updater Bot changed the title "tbd" refactor: migrate to keyring-core and reusable workflows Apr 10, 2026
@WeekendSuperhero
WeekendSuperhero merged commit 6d5ce1d into main Apr 10, 2026
13 checks passed
@WeekendSuperhero
WeekendSuperhero deleted the weekendsuperhero/css_cleanup branch April 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants