Skip to content

Defensive changes: fix for another strict weak ordering violation #187

@shewitt-au

Description

@shewitt-au

Overview

Some time ago I fixed a crash related to sorting in the pattern drawer. The cause was a sort predicate that did not implement strict weak ordering correctly. I have revisited this and found (and fixed) another violation (transitivity of incomparability).

I can not verify that this causes crashes in the real world. It is an incorrect sort predicate and that has caused crahses in the past.

More details in this PR

The PR also links to a repo I wrote with a small test program to show how a bad sort predicate can be catastrophic .

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions