Merged
Conversation
The pattern language evaluator uses storage whose size is calculated using the value offset. When a base address has been set that is not zero, the offset will then increase and so will the storage allocated. To correct this we detect when patterns are using the main section to calculate the storage size based on offset that has the base address removed.
…iable was using the offset of the instance inside the input file (value->getOffset()) to calculate the heap storage size instead of using the offset of the instance inside the pattern that occupies the heap (pattern->getOffset()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern language evaluator uses storage whose size is calculated using the value offset. When a base address has been set that is not zero, the storage allocated is set incorrectly. This PR attempts to correct this by detecting when the value is from the main section and in that case removing the base address from the offset so that the storage size becomes independent of the base address.