ci(play): fix gradlew exec bit and align store password secret#42
Merged
Merged
Conversation
Two fixes for the failing 'Publish to Google Play' run (#41 follow-up): 1. gradlew was committed with mode 100644, so the runner refused to execute it ('./gradlew: Permission denied', exit 126). Set the execute bit in the index via 'git update-index --chmod=+x gradlew' so checkouts on Linux runners can invoke it directly. 2. The workflow read the store password from a secret named ANDROID_KEYSTORE_PASSWORD, but the matching Gradle property in app/build.gradle is ANDROID_STORE_PASSWORD. Renamed the workflow reference + README documentation to ANDROID_STORE_PASSWORD so all five secrets line up 1:1 with the Gradle property names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the first failing run of the Publish to Google Play workflow:
gradlewwas 100644 in the repo, so the Ubuntu runner failed with./gradlew: Permission denied(exit 126). Set the execute bit in the index withgit update-index --chmod=+x gradlew. This is the right long-term fix — it lives in git's tree and works for every checkout, nochmodstep required in the workflow.Secret name mismatch. The workflow referenced
secrets.ANDROID_KEYSTORE_PASSWORDbut the Gradle property inapp/build.gradleisANDROID_STORE_PASSWORD, and that's the name the secret was actually created under. Renamed both the workflow reference and the README table toANDROID_STORE_PASSWORDso all five secrets line up 1:1 with the Gradle properties they feed.Caught from the failed run logs at https://github.com/WhenApp/WhenApp-Android/actions/runs/25323562875.