Skip to content

Add false-positive evidence facets to audit recipes #3929

Description

@Widthdom

Latest dogfood scans showed several audit recipes are useful but too binary: they report the raw pattern without enough evidence to separate risky code from already-bounded or intentional code.

Examples:

  • cancellation-token-none reports documented sync compatibility wrappers and timeout-cleanup continuations alongside real cancellation gaps.
  • sync-over-async reports documented process-boundary bridges.
  • broad-exception-catch mixes top-level command boundaries with swallowed diagnostic paths.
  • raw-diagnostic-echo does not distinguish outputs already passed through DiagnosticRedactor / CommandErrorWriter.FormatSanitizedException.
  • path-case-heuristic reports protocol tokens, CLI option names, and label/name comparisons in addition to path equality.
  • process-start-info reports safe shared wrappers and direct launch sites with the same weight.
  • full-materialization and max-value-probe report code with explicit size/saturation comments and bounds.
  • authorization-handling reports SQL ALTER AUTHORIZATION references as auth-boundary hits.

Requested improvement: add recipe result facets, suppression hints, or query refinements that expose why a hit is risky versus likely-safe, e.g. bounded wrapper, top-level boundary, sanitizer present, protocol/non-path domain, safe process wrapper, or known saturation helper.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions