Fix index batch recovery marker - #2593
Merged
Merged
Conversation
# Conflicts: # src/CodeIndex/Indexer/Symbols/SymbolExtractor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codeindex_meta.batch_in_progress=truebefore index write batches and clear it inside the committing transaction.origin/main.Fixes #2109
Fixes #2609
Validation
dotnet build CodeIndex.sln -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false --filter "FullyQualifiedName~DatabaseTests"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false --filter "FullyQualifiedName~IndexCommandRunnerTests.Run_FullScan_CancelledAfterReadinessDemotion_RollsBackExistingIndex"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false --filter "FullyQualifiedName~SymbolExtractorTests.Extract_RustTraitAssociatedTypeDefaults_RecordsPropertySymbols|FullyQualifiedName~DatabaseTests"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~DatabaseTests|FullyQualifiedName~IndexCommandRunnerTests.FullScanInterruptedDuringWritePhaseRollsBackReadinessDemotion|FullyQualifiedName~SymbolExtractorTests"(adversarial review session; 1112 passed on net8.0 and net9.0)dotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkDocumentation and Changelog
DEVELOPER_GUIDE.md.changelog.d/unreleased/2109.fixed.md.changelog.d/unreleased/2609.fixed.md.Review
PRAGMA user_versionon writable open whenbatch_in_progress=true.interfacecontainers even though Rust traits areprotocol; fixed under Rust associated type defaults are skipped under trait containers #2609.Follow-up candidates
Notes
dotnet test CodeIndex.sln -p:UseSharedCompilation=falsewas attempted but stopped after several minutes without progress while other worktree test runs were also active in the environment.