Skip to content

Fix index batch recovery marker - #2593

Merged
Widthdom merged 7 commits into
mainfrom
fix-issue2109
May 24, 2026
Merged

Fix index batch recovery marker#2593
Widthdom merged 7 commits into
mainfrom
fix-issue2109

Conversation

@Widthdom

@Widthdom Widthdom commented May 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Stamp codeindex_meta.batch_in_progress=true before index write batches and clear it inside the committing transaction.
  • Warn and demote readiness bits on the next writable DB open when an orphaned batch marker remains.
  • Cover committed vs rolled-back marker behavior with DB tests and document the recovery contract.
  • Fix the CI-blocking Rust associated type default extractor regression found after merging latest origin/main.

Fixes #2109
Fixes #2609

Validation

  • dotnet build CodeIndex.sln -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false --filter "FullyQualifiedName~DatabaseTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false --filter "FullyQualifiedName~IndexCommandRunnerTests.Run_FullScan_CancelledAfterReadinessDemotion_RollsBackExistingIndex"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -p:UseSharedCompilation=false --filter "FullyQualifiedName~SymbolExtractorTests.Extract_RustTraitAssociatedTypeDefaults_RecordsPropertySymbols|FullyQualifiedName~DatabaseTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~DatabaseTests|FullyQualifiedName~IndexCommandRunnerTests.FullScanInterruptedDuringWritePhaseRollsBackReadinessDemotion|FullyQualifiedName~SymbolExtractorTests" (adversarial review session; 1112 passed on net8.0 and net9.0)
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • git diff --check

Documentation and Changelog

  • Updated DEVELOPER_GUIDE.md.
  • Added changelog.d/unreleased/2109.fixed.md.
  • Added changelog.d/unreleased/2609.fixed.md.

Review

Follow-up candidates

  • None.

Notes

  • Full dotnet test CodeIndex.sln -p:UseSharedCompilation=false was attempted but stopped after several minutes without progress while other worktree test runs were also active in the environment.

@Widthdom
Widthdom merged commit 76d19f0 into main May 24, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2109 branch May 24, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust associated type defaults are skipped under trait containers Transaction rollback does not preserve DB integrity marker

1 participant