Skip to content

Emit MCP progress notifications - #2635

Merged
Widthdom merged 1 commit into
mainfrom
codex/fix-issue1684
May 24, 2026
Merged

Emit MCP progress notifications#2635
Widthdom merged 1 commit into
mainfrom
codex/fix-issue1684

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Emit MCP notifications/progress for index and backfill_fold when _meta.progressToken is supplied.
  • Route stdio progress as out-of-band frames and HTTP progress through the existing /events SSE stream so POST responses still return the final tool result.
  • Document the progressToken behavior in MCP tool descriptions and add a bilingual changelog fragment.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~McpServerTests.RunAsync_IndexWithProgressToken_EmitsProgressNotificationBeforeResult|FullyQualifiedName~McpServerTests.RunAsync_NonStreamingIndexWithProgressToken_ReturnsFinalResultWithoutProgress|FullyQualifiedName~HttpMcpTransportTests.HttpTransport_IndexWithProgressToken_EmitsProgressOnEventsStreamAndReturnsResult"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~HttpMcpTransportTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~McpServerTests"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test was also run; net9.0 passed, and net8.0 had one transient trimmed-publish file lock in QueryCommandRunnerTests.RunPublishedTrimmedCli_SearchSupportsCSharpRazorAliases(lang: "cshtml"). Re-running that net8.0 test passed.

Documentation / Changelog

  • Updated MCP tool descriptions for index and backfill_fold.
  • Added changelog.d/unreleased/1684.fixed.md.

Review

  • Codex adversarial review found an HTTP one-shot response regression in the first implementation.
  • Addressed by sending HTTP progress over /events SSE instead of the POST response writer.
  • A second Codex review attempt was blocked by the local Codex usage limit.

Fixes #1684

@Widthdom
Widthdom marked this pull request as ready for review May 24, 2026 13:45
@Widthdom
Widthdom merged commit d9e83a9 into main May 24, 2026
10 checks passed
@Widthdom
Widthdom deleted the codex/fix-issue1684 branch May 24, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long-running index / backfill_fold tools emit no notifications/progress events

1 participant