Skip to content

Fix git fixture signing and stderr tee failures - #2741

Merged
Widthdom merged 2 commits into
mainfrom
fix-issue2729-2730
May 31, 2026
Merged

Fix git fixture signing and stderr tee failures#2741
Widthdom merged 2 commits into
mainfrom
fix-issue2729-2730

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Disable commit/tag signing in Git-backed test fixture repositories so global signing settings cannot break non-interactive fixture commits.
  • Harden persistent stderr tee logging so disposed console/log writers do not cascade ObjectDisposedException into callers.

Validation

  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~IndexCommandRunnerTests|FullyQualifiedName~GitHelperTests|FullyQualifiedName~GitTestProjectHelperTests"
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~GlobalToolLogTests|FullyQualifiedName~HttpMcpTransportTests"
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • dotnet test CodeIndex.sln -p:UseSharedCompilation=false

Documentation and Changelog

  • Updated TESTING_GUIDE.md Git test guidance.
  • Added changelog.d/unreleased/2729.fixed.md.
  • Added changelog.d/unreleased/2730.fixed.md.

Review

  • Manual adversarial review of origin/main..HEAD: no blocking/actionable issues found.
  • Attempted required codex exec adversarial review, but it was blocked by Codex usage limits in this environment.

Follow-up

Fixes #2729
Fixes #2730

@Widthdom
Widthdom marked this pull request as ready for review May 31, 2026 07:22
@Widthdom
Widthdom merged commit db9a4c7 into main May 31, 2026
10 checks passed
@Widthdom
Widthdom deleted the fix-issue2729-2730 branch June 3, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant