Harden DbWriter transaction coverage and metadata writes - #2745
Merged
Conversation
Widthdom
force-pushed
the
fix-issue1669-1735-1753
branch
from
May 31, 2026 10:05
b198b83 to
21dfee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetUnchangedFileIdchecksum-drift behavior with regression coverage.SetMetajoin writer transaction boundaries or use a standalone SQLite savepoint, with metadata rollback tests and developer documentation.Validation
dotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~DatabaseTests|FullyQualifiedName~PreparedCommandCacheTests" -p:UseSharedCompilation=falsedotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falseDocumentation / Changelog
DEVELOPER_GUIDE.mdchangelog.d/unreleased/1669.internal.mdchangelog.d/unreleased/1735.fixed.mdchangelog.d/unreleased/1753.fixed.mdFollow-up References
Fixes #1669
Fixes #1735
Fixes #1753