Skip to content

Fix type alias target graph edges - #2783

Closed
Widthdom wants to merge 2 commits into
mainfrom
fix-issue1976
Closed

Fix type alias target graph edges#2783
Widthdom wants to merge 2 commits into
mainfrom
fix-issue1976

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Add explicit type_alias_target references for Swift and TypeScript type alias RHS expressions.
  • Include type_alias_target in graph traversal reference kinds and the valid reference-kind catalog.
  • Add regression coverage for Swift and TypeScript alias target edges.

Validation

  • dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --framework net8.0 --filter "FullyQualifiedName~ReferenceExtractorTests.Extract_TypeScriptTypeAliasGenericDefaults_EmitsDefaultAndRhsTypeReferences|FullyQualifiedName~ReferenceExtractorTests.Extract_SwiftTypealiasRhs_RecordsReferencedTypes|FullyQualifiedName~QueryCommandRunnerTests.RunSymbols_SwiftKindFiltersSeparateTypealiasAssociatedtypeAndProtocol" -p:UseSharedCompilation=false
  • dotnet run --project tools/CodeIndex.Changelog -- check

Documentation and Changelog

  • Added changelog fragment changelog.d/unreleased/1976.fixed.md.

Review

  • Adversarial review: No blocking/actionable issues found.

Fixes #1976

@Widthdom
Widthdom marked this pull request as ready for review May 31, 2026 15:34

Copy link
Copy Markdown
Owner Author

Closing without merge because #1976 was already completed by #2785 (merged into main as 9d90261). That PR added the changelog fragment changelog.d/unreleased/1976.fixed.md and the corresponding implementation/tests, so this PR now conflicts with main and is superseded.

@Widthdom Widthdom closed this May 31, 2026
@Widthdom
Widthdom deleted the fix-issue1976 branch May 31, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kind not propagated through type alias indirection

1 participant