Harden package metadata normalization - #2925
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeIndex.PackageNormalizeZIP entry count, declared entry sizes, total uncompressed size, XML text size, and actual inflated read budgets before rewriting packages.CreateEntry, including absolute paths, drive roots, traversal, backslashes, empty segments, and normalized duplicate destination names.Validation
dotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~ReleaseWorkflowTests"dotnet test --no-build(full suite; run before the final adversarial-review follow-up commits)dotnet run --project tools/CodeIndex.Changelog -- checkdotnet format CodeIndex.sln --verify-no-changesdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNo blocking/actionable issues found.Documentation and changelog
DEVELOPER_GUIDE.mdchangelog.d/unreleased/:changelog.d/unreleased/2892.security.mdchangelog.d/unreleased/2894.security.md.codex/workflows/changelog-fragment.mdfor category, issue front matter, and bilingual sections.Issues
Fixes #2892
Fixes #2894
Follow-up issues