[codex] Fix index watch failure handling - #2956
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index --watchsub-run failures by emitting failed watch batch events withexit_code, adding exit codes to human summaries, and returning the latest non-zero sub-run exit code when watch mode stops.Documentation / Changelog
USER_GUIDE.mdwatch-mode behavior in English and Japanese.changelog.d/unreleased/2902.fixed.mdchangelog.d/unreleased/2903.fixed.mdValidation
dotnet builddotnet run --project tools/CodeIndex.Changelog -- checkdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~IndexWatchRunnerTests"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -f net9.0 --filter "FullyQualifiedName~InvokeSubRunAndEmit"dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNo blocking/actionable issues found.Full-suite
dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restorewas attempted; unrelated ambient workspace failures were filed as follow-up #2951.Issues
Fixes #2902
Fixes #2903
Follow-up: #2951