Bound subprocess execution for git helpers and upgrade installer - #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdidx upgradeinstaller withProcessStartInfo.ArgumentListand terminate stalled installer runs with a clear error.Validation
dotnet build -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~GitHelperTests -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter FullyQualifiedName~ProgramRunnerTests -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkdotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsecodex exec review --base origin/main --ephemeralwas attempted twice but blocked by Codex usage/model availability limits in this environment.Documentation / Changelog
changelog.d/unreleased/2832.fixed.md.changelog.d/unreleased/2827.fixed.md.CHANGELOG.mdupdate; ordinary issue-fix fragments were used.Follow-up Candidates
Fixes #2832
Fixes #2827