Fix DbPathResolver query tests active workspace isolation - #2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolveDataDirForQuery_*tests from developer-local active workspace state.Root Cause
ResolveDataDirForQuerycorrectly checks active workspace state before ancestor.cdidxand XDG resolution. The affected tests did not clearCDIDX_ACTIVE_WORKSPACEor isolateXDG_CONFIG_HOME, so local active workspace configuration could redirect the expected test DB path.Validation
CDIDX_ACTIVE_WORKSPACE=/tmp/cdidx_active_workspace/codeindex.db dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore -p:UseSharedCompilation=false --filter "FullyQualifiedName~DbPathResolverTests.ResolveDataDirForQuery"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-restore -p:UseSharedCompilation=false --filter "FullyQualifiedName~DbPathResolverTests"dotnet run --project tools/CodeIndex.Changelog -- checkdotnet format CodeIndex.sln --verify-no-changes --no-restoredotnet build CodeIndex.sln --no-restore -p:UseSharedCompilation=falsedotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNo blocking/actionable issues found.Documentation / Changelog
changelog.d/unreleased/2953.fixed.md.AGENT.md,CLAUDE.md, orAGENT_GUIDE.mdchanges.Follow-up Candidates
None.
Fixes #2953