[codex] Bound MCP progress tokens - #3300
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_meta.progressTokenbefore cloning or echoing it in MCP progress notifications.index/backfill_foldtool descriptions and adds regression coverage for accepted and rejected tokens.Validation
dotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~McpServerTests.RunAsync_IndexWithdotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --no-build --filter FullyQualifiedName~HttpMcpTransportTests.HttpTransport_IndexWithProgressTokendotnet run --project tools/CodeIndex.Changelog -- checkdotnet format CodeIndex.sln --verify-no-changesgit diff --checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsoncodex exec review --base origin/main --dangerously-bypass-approvals-and-sandbox --dangerously-bypass-hook-trustDocumentation / Changelog
changelog.d/unreleased/3103.security.mdindexandbackfill_foldwere updated.Follow-ups
Fixes #3103