Fix main CI duplicate request token declaration - #3861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestTokenlocal declaration in MCP status handling that broke Release builds after Fix cancellation, heartbeat, and LSP symbol budget issues #3854 merged.CI Root Cause
Build and Test / build (windows-latest, net9.0)failed withCS0128: A local variable or function named 'requestToken' is already defined in this scopeatsrc/CodeIndex/Mcp/McpToolHandlers.cs(3180,17).CodeQL / Analyze (csharp)failed for the same build error during its solution build.Validation
dotnet restore CodeIndex.sln --locked-modedotnet build tests/CodeIndex.Tests/CodeIndex.Tests.csproj --configuration Release --framework net9.0 --no-restore -p:UseSharedCompilation=falsedotnet build CodeIndex.sln --configuration Release --no-restore -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --configuration Release --no-build --filter ToolsCall_StatusUpdateCheck_UsesRequestCancellationToken_Issue3658 -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkgit diff --check origin/main...HEADdotnet build -p:UseSharedCompilation=falsedotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index . --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsonNo changelog fragment: this is a CI build repair for an already-merged change and does not alter user-visible behavior.
Refs #3854