Skip to content

Fix search aggregation row and byte limits - #4215

Merged
Widthdom merged 4 commits into
mainfrom
codex/issue-4119-search-limits-final
Jun 28, 2026
Merged

Fix search aggregation row and byte limits#4215
Widthdom merged 4 commits into
mainfrom
codex/issue-4119-search-limits-final

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • Apply --limit to grouped/count-by/unique search group rows and expose returned/total group metadata.
  • Enforce --max-json-bytes on accepted search JSON outputs, including count, compact, grouped, projected arrays, recipe aggregation, named-query compact JSON, and zero-result NDJSON/grouped/compact paths.
  • Add regression coverage and an unreleased changelog fragment.

Validation

  • dotnet build src/CodeIndex/CodeIndex.csproj --framework net8.0 --no-restore -p:UseSharedCompilation=false -p:BuildInParallel=false -p:RunAnalyzers=false -m:1
  • dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --framework net8.0 --no-restore -p:RunAnalyzers=false with the targeted search regression filter for 8 tests.
  • dotnet run --project tools/CodeIndex.Changelog -- check
  • git diff --check origin/main..HEAD
  • dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --json
  • CLI smoke: zero-result NDJSON with --max-json-bytes 1 returns done:false and interrupted:true.
  • Codex adversarial review: No blocking/actionable issues found.

Changelog

  • changelog.d/unreleased/4119.fixed.md

Fixes #4119

@Widthdom
Widthdom marked this pull request as ready for review June 28, 2026 18:03
@Widthdom
Widthdom merged commit 88c851c into main Jun 28, 2026
10 checks passed
@Widthdom
Widthdom deleted the codex/issue-4119-search-limits-final branch June 28, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make search grouped output honor intuitive row and byte limits

1 participant