Stabilize SQLite policy audits and maintenance JSON - #4366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite-query-policy-surfacesfor shared command creation, typed parameter helpers, identifier quoting, and PRAGMA helper usage.E008_DB_ERRORJSON envelope for early corrupt SQLite DB failures instatus --jsonwhile preserving existing stderr behavior after a DB is query-ready.wal_checkpoint_timing_noteto realvacuum --jsonoutput and document the WAL checkpoint timing caveat in the English and Japanese developer guide sections.Validation
dotnet build CodeIndex.sln -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunSearch_ListRecipesJsonIncludesBuiltInAuditMetadata_Issue3144|FullyQualifiedName~RunSearch_BuiltInRecipeSnapshotCoversNamesScopesAndQueries_Issue3692" -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunDefinition_CountOnlyOnReadOnlyDbMissingChunks_FailsLikeDefinition|FullyQualifiedName~RunStatus_CorruptDbJsonReturnsStructuredError_Issue4338|FullyQualifiedName~RunVacuum_JsonExplainsWalCheckpointTiming_Issue4338|FullyQualifiedName~WithDb_OpenFailureBranchesSanitizeExceptionMessages_Issue4124" -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -f net8.0 -p:UseSharedCompilation=falseReleaseWorkflow_DockerEntrypointDropsRootToRequestedUidGidtimeout, and the net8-only rerun above passed.dotnet run --project tools/CodeIndex.Changelog -- checkdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll status --check --jsondotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll search --recipe sqlite-query-policy-surfaces --format count --summary-only --json --limit 5Documentation And Changelog
DEVELOPER_GUIDE.mdin both English and Japanese sections for thevacuum --jsonWAL timing note.changelog.d/unreleased/4302.fixed.md.changelog.d/unreleased/4338.fixed.md.Review
Follow-Ups
Fixes #4302
Fixes #4338