Fix C# symbol extraction edge cases - #4487
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constandstatic readonlydeclarations asfieldsymbolsoutmodifiers, static lambdas, and raw-string SQL contents with focused regression testsRoot cause and impact
The field patterns historically used the function extraction path, and multiline tuple return headers were not recognized when the opening tuple parenthesis ended the modifier line. This polluted symbol kinds or lost the real method name. The updated classification preserves the mature scanning path while correcting the emitted kind, and the tuple-prefix recognizer lets the existing bounded header merger assemble the declaration correctly.
Validation
dotnet run --project tools/CodeIndex.Changelog -- checkdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-buildNo blocking/actionable issues found.Documentation and changelog
Bilingual changelog fragments:
changelog.d/unreleased/4405.fixed.mdchangelog.d/unreleased/4413.fixed.mdchangelog.d/unreleased/4453.fixed.mdchangelog.d/unreleased/4454.fixed.mdchangelog.d/unreleased/4456.fixed.mdNo standalone documentation contract changed.
Follow-up candidates
None.
Fixes #4405
Fixes #4413
Fixes #4453
Fixes #4454
Fixes #4456