Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static readonlyraw-string fields, same-lineconstraw-string fields, and long object/collection initializerssymbols/outlineoutput so signature truncation is caught end-to-endRoot Cause
The earlier #447 perf fix capped multiline lookahead, but confirmed field declarations still depended on partial candidate assembly when building stored signatures. That left long raw-string declarations, especially same-line
constfields, truncated at the opener line even though the symbol itself still existed.Impact
symbols,definition, andoutlinenow retain the full declaration signature for long multiline C# fields instead of stopping atstringor""".Validation
dotnet builddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~SymbolExtractorTests"dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj --filter "FullyQualifiedName~RunSymbolsAndOutline_CSharpLongRawStringFields_PreserveFullSignature"dotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dllon temporary projects to verifysymbolsandoutlineoutput for long raw-string fieldsCloses #447.