Stabilize C# large-switch performance guard - #4803
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The broad wall-clock runaway guard used an 8-second threshold that behaved like a benchmark under full-suite host contention. In the validated Release/net8.0 full suite, the target test took 9 seconds, while isolated runs took 2–4 seconds. The extraction result remained correct; the failure was caused by insufficient load margin.
Validation
dotnet run --project tools/CodeIndex.Changelog -- checkmake lintdotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falseDocumentation and changelog
TESTING_GUIDE.mdchangelog.d/unreleased/4792.internal.mdFollow-ups
Fixes #4792