Decompose large indexing, CLI, and service components - #4816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SymbolExtractor,ReferenceExtractor, full-scan/update orchestration, and language-specific extraction paths.Why
Several core classes and methods had accumulated unrelated responsibilities, making changes difficult to review and increasing the risk of behavioral drift. This refactor separates coherent phases and language-specific concerns while keeping transaction ordering and state aggregation in their existing orchestration boundaries.
Impact
This is intended to be behavior-preserving. It improves maintainability, test isolation, and ownership boundaries without retaining public CLI, MCP, database, or indexing contract changes.
Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— 0 warnings, 0 errorsNo blocking/actionable issues found.Documentation and changelog
No documentation or changelog fragment was added because the final diff is an internal, behavior-preserving refactor. A transient user-visible MCP suggestion change found during adversarial review was reverted before publication.
Follow-up candidates
notifications/roots/list_changedto the unknown-method guidance as a user-visible MCP UX improvement, with its own bilingual changelog fragment.