Fix discovery JSON shape consistency#4928
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 27, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symbolsandfilesdiscovery row serialization across NDJSON, arrays, and envelopes.resultswhile preserving exact-readiness and truthful pagination metadata, including empty and summary-only cases.Root cause
The bounded envelope wrapper treated any first discovery JSON object as a nested payload, relocating a flat row into response context. Raw symbol arrays also bypassed the discovery-row builder that adds exact readiness.
Documentation and changelog
DEVELOPER_GUIDE.md.changelog.d/unreleased/4835.fixed.md.Validation
dotnet restore CodeIndex.slndotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=falsedotnet test CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-build(10,517 passed; 7 skipped; 0 failed)dotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --no-restore --filter "FullyQualifiedName~JsonEnvelopeWrapper|FullyQualifiedName~QueryCommandRunnerIssue4835Tests" -p:UseSharedCompilation=false(41 passed on each of .NET 8 and .NET 9)dotnet run --project tools/CodeIndex.Changelog -- checkFollow-up candidates
None.
Fixes #4835