Skip to content

Fix innermost C# callable containment - #4933

Merged
Widthdom merged 5 commits into
mainfrom
fix-issue4840
Jul 27, 2026
Merged

Fix innermost C# callable containment#4933
Widthdom merged 5 commits into
mainfrom
fix-issue4840

Conversation

@Widthdom

Copy link
Copy Markdown
Owner

Summary

  • select the innermost C# callable container consistently for reference and symbol extraction, including test.method, local functions, nested local functions, lambdas, expression-bodied methods, and nested types
  • keep callable-first tie-breaking scoped to C#, preserve compact non-C# behavior, and handle shortened callable ranges plus primary-constructor boundaries
  • add focused regressions for issue Preserve innermost callable containment for C# calls, local functions, and lambdas #4840 and both adversarial-review rounds

Validation

  • dotnet build CodeIndex.sln --no-restore -c Release -m:1 -p:UseSharedCompilation=false -nodeReuse:false (0 warnings, 0 errors)
  • issue/review tests: .NET 8 6 passed; .NET 9 6 passed
  • Reference/Symbol extractor suite: .NET 8 2,414 passed; .NET 9 2,389 passed, 25 skipped
  • full Release suite: .NET 9 10,110 passed, 419 skipped; .NET 8 10,581 passed, 7 skipped, with two unrelated load-sensitive tests failing during three concurrent repository-wide runs and then passing 2/2 in an isolated rerun
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore
  • dotnet run --project tools/CodeIndex.Changelog --no-build -c Release -- check
  • git diff --check origin/main...HEAD
  • two rounds of Codex adversarial review completed; all actionable findings were addressed

Documentation and changelog

Follow-up candidates

None.

Fixes #4840

@Widthdom
Widthdom marked this pull request as ready for review July 27, 2026 13:54
@Widthdom
Widthdom merged commit e92d37a into main Jul 27, 2026
12 checks passed
@Widthdom
Widthdom deleted the fix-issue4840 branch July 27, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve innermost callable containment for C# calls, local functions, and lambdas

1 participant