Normalize maintenance database error handling - #4949
Merged
Conversation
# Conflicts: # USER_GUIDE.md # src/CodeIndex/Cli/CliContractManifest.cs # src/CodeIndex/Cli/CommandErrorCodes.cs
Widthdom
marked this pull request as ready for review
July 28, 2026 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vacuum,backfill-fold,optimize/index --optimize, anddb integrityfailures behind a versioned maintenance database classifier--show-pathsas the explicit diagnostic opt-inValidation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false(0 warnings, 0 errors)dotnet format CodeIndex.sln --verify-no-changes --no-restore --verbosity minimaldotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkcdidx status --check --json:index_matches_workspace: trueAdversarial review
Two Codex adversarial-review rounds were completed. Actionable findings around newer-schema and retry-exhausted lock preservation, whole-path redaction,
index --optimizepreamble leakage, inaccessible preflight targets, relative-path spelling, and lock-holder details were addressed with regression coverage.Documentation and changelog
USER_GUIDE.mdTESTING_GUIDE.mdDEVELOPER_GUIDE.mdchangelog.d/unreleased/4856.fixed.mdRelated: #1526, #4338
Fixes #4856