Classify MCP catalog descriptions as non-executable origins - #4963
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 28, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema_descriptionRoot cause
MCP tool catalog construction moved from
McpToolDefinitions.cstoMcpToolCatalog.cs, while origin classification still recognized only the old path and direct description assignments. Top-levelCreateToolDefinitiondescriptions, concatenated segments, and catalog descriptions containingRegextherefore retained executable/string-oriented origins instead of the canonicalschema_descriptionorigin introduced by #4416.Validation
dotnet format CodeIndex.sln --no-restore --verify-no-changes: passBCL Regex timeout audit rowsresolves only asschema_description; thenew HttpClientaudit returns only executable C# evidenceDocumentation / changelog
changelog.d/unreleased/4864.fixed.mdwith English and Japanese entriesFixes #4864