Reject invalid LSP coordinates as InvalidParams - #4967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PositionandRangestructural validation before document, live-text, and index access.-32602for malformed, negative, overflowing, missing, or reversed request coordinates while preserving valid UTF-16 and EOF behavior.didChangenotifications before they can mutate accepted live text.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false— passed with 0 warnings and 0 errors.net8.0andnet9.0— 3 passed on each target.net8.0suite — 10,777 passed, 7 expected skips, 0 failed.net9.0suite — 10,302 passed, 420 expected skips; one unrelated watcher timeout is tracked in Investigate net9 ancestor .gitignore watcher reconciliation timeout #4966.dotnet format CodeIndex.sln --verify-no-changes --no-restore— passed.dotnet run --project tools/CodeIndex.Changelog -- check— validated all 41 fragments.status --check --json— fresh, clean, and matched to HEAD.origin/main..HEAD—No blocking/actionable issues found.Documentation and changelog
DEVELOPER_GUIDE.md.TESTING_GUIDE.md.changelog.d/unreleased/4869.fixed.md.Follow-up candidates
Fixes #4869