Fix JSON array symbol hierarchy - #4973
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and impact
Array indices and object-property boundaries shared path-composition logic, which could duplicate parent names or conflate literal bracket-prefixed keys with array elements. Line lookup also depended on raw-text matching, so comments, bounded skips, compact files, and empty property names could misalign later symbols. As a result, symbols, definitions, and outlines could expose incorrect paths, parents, depths, or signatures for valid JSON/JSONL inputs.
The updated extraction and outline contracts now preserve an unambiguous hierarchy across those cases.
Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— succeeded with 0 warnings and 0 errors.net8.0andnet9.0— 10 passed on each framework.net8.0— 24 passed.net8.0— 50 passed.net8.0suite — 10,809 passed, 7 skipped, 0 failed.net9.0suite — 10,334 passed, 420 skipped, with one unrelated filesystem-watcher test failure already tracked by Use one membership and invalidation policy for scan, status, and watch #4592; the same test failed in isolation under concurrent load, while itsnet8.0full-suite run passed.dotnet format CodeIndex.sln --no-restore --verify-no-changes— passed.git diff --check— passed.Documentation and changelog
DEVELOPER_GUIDE.md.changelog.d/unreleased/4874.fixed.md.Follow-up candidates
Fixes #4874