Add canonical member-read references - #5003
Merged
Merged
Conversation
# Conflicts: # src/CodeIndex/Mcp/McpToolArgumentContracts.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
member_readedges for non-invoking C# enum constants, constants, static readonly fields, static properties, and constant-pattern reads.call, suppress callable-name collision duplicates, and resolve same-file and cross-file member-read targets.--include-member-readsand MCPincludeMemberReadscompatibility controls.callrows without requiring migration.--files, commit-based, watch-style, and MCP indexing correct when consumers or member-read targets are added, changed, removed, or reused.Root cause
Qualified C# value/member access was historically classified through the callable-name path, so enum constants and other static value reads could be persisted as
call. The initial fix also needed workspace-wide target knowledge during incremental indexing: consumer-only scoped updates could omit cross-filemember_readedges, while target-set changes could leave reusable consumers stale.Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=falsedotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --framework net8.0— 10,971 passed, 0 failed, 7 skippeddotnet test tests/CodeIndex.Tests/CodeIndex.Tests.csproj -c Release --no-build --framework net9.0— 10,497 passed, 0 failed, 420 skippedorigin/main, repeated the Release build and focused Issue Add a member-read reference kind without breaking legacy call graphs #4894 / MCP contract / language-pagination tests: net8 25 passed; net9 24 passed, 1 expected skipdotnet format CodeIndex.sln --no-restore --verify-no-changes --verbosity minimaldotnet run --project tools/CodeIndex.Changelog -- checkgit diff --checkindex_matches_workspace: true, graph complete/current, and zero cap hitsDocumentation and changelog
USER_GUIDE.md,DEVELOPER_GUIDE.md, andTESTING_GUIDE.mdin their English and Japanese sections.changelog.d/unreleased/4894.added.md.Follow-ups
None.
Fixes #4894